make ap@k jittable #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffcarp
reviewed
Apr 3, 2025
| OUTPUT_LABELS_VS1, | ||
| OUTPUT_PREDS_VS1, | ||
| MAP_FROM_KERAS_VS1, | ||
| ), |
There was a problem hiding this comment.
Since this test is mostly the same could it be combined with the above and add another parameterized option for whether to jit or not?
There was a problem hiding this comment.
modified accordingly.
jeffcarp
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes AP@K jittable. However, it removes an optimization which used to slice the given label/prediction by the maximum k. Slicing a matrix makes the function impure. I think this is a fair tradeoff. Please let me know if you think otherwise! :)