fix modelviewer.dev deployment error #5001
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly, upgraded to threejs r171, and updated packages to the latest version.
…ove appendAnimation method, format codes with clang-format style and fix other requested changes in google#4979 pull request
…of appendAnimation function, improve modelviewer.dev styles and revert dependencies version
…improve general performance
…ncy error when installing in postprocessing
…ditor, improve modelviewer.dev hamburger menu
…ncies, fix ar-usdz-docs.json "max-texture-size" attribute defualt value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi dear @diegoteran
Pull Request Description:
This PR addresses several issues and improvements for the
model-viewerproject:Deployment Error Fix:
Resolves a deployment error encountered on
modelviewer.dev. The changes have been tested locally and are confirmed to work correctly.Three.js Upgrade:
Upgrades the project to use Three.js r173 to ensure compatibility with the latest features and improvements.
Dependency Updates:
Updates all project dependencies to their latest stable versions to maintain security and performance.
Documentation Fix:
Corrects the documentation for the
ar-usdz-max-texture-sizeattribute by clarifying its default value.