Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1077: Deprecate Mozc_tsf_ui.log #1078

Merged
merged 1 commit into from
Oct 15, 2024

Commits on Oct 14, 2024

  1. Fix google#1077: Deprecate Mozc_tsf_ui.log

    This commit affects only mozc_tip{32,64}.dll build with debug mode.
    There must be no behavior change in release build.
    
    Currently 'Mozc_tsf_ui.log' is created only when NDEBUG is defined.
    With this commit we stop creating it even when NDEBUG is defined.
    This addresses a crash issue in debug builds discussed in google#1077.
    
    See google#856 about why absl::LocalTimeZone cannot be used in Windows right
    now.
    
    Note that this commit may also help us diagnose google#1076, where
      Windows.Storage.OneCore.dll
    looks to be intercepting certain Win32 file I/O API calls in
    AppContainer processes then trigger RoInitialize as needed.
    Creating 'Mozc_tsf_ui.log' only in debug builds can make our debugging
    more complicated.
    yukawa committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    49e1e0f View commit details
    Browse the repository at this point in the history