Remove the shouldPublish field from the reservedLIst entity

google · Mar 13, 2024 · 7026a51 · 7026a51
1 parent 9af0068
commit 7026a51
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/core/src/main/java/google/registry/model/tld/label/ReservedList.java b/core/src/main/java/google/registry/model/tld/label/ReservedList.java
@@ -71,10 +71,6 @@ public final class ReservedList
    */
   @Insignificant @Transient Map<String, ReservedListEntry> reservedListMap;
 
-  // TODO(b/321053918): Remove this field once the column is nullable
-  @Column(nullable = true)
-  boolean shouldPublish = true;
-
   @PreRemove
   void preRemove() {
     tm().query("DELETE FROM ReservedEntry WHERE revision_id = :revisionId")

diff --git a/core/src/test/java/google/registry/tools/server/ListReservedListsActionTest.java b/core/src/test/java/google/registry/tools/server/ListReservedListsActionTest.java
@@ -69,7 +69,7 @@ void testRun_withWildcard() {
         Optional.of("*"),
         Optional.empty(),
         Optional.empty(),
-        "^name\\s+.*shouldPublish.*",
+        "^name\\s+.*",
         "^-+\\s+-+",
         "^xn--q9jyb4c-private\\s+.*",
         "^xn--q9jyb4c-published\\s+.*");

diff --git a/gradle.properties b/gradle.properties
@@ -1,4 +1,4 @@
-# This file defines properties used by the Gradle build. It must be kept in
+# This file defines properties used by the gradle build.  It must be kept in
 # sync with config/nom_build.py.
 #
 # To regenerate, run ./nom_build --generate-gradle-properties