-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BSA mockup for the design doc #2198
Conversation
e418d3d
to
3300559
Compare
checkArgument(columns.size() == 2, "Invalid line: [%s]", line); | ||
checkArgument(!Strings.isNullOrEmpty(columns.get(0)), "Missing label in line: [%s]", line); | ||
ImmutableList<Long> orderIds = | ||
ORDER_SPLITTER.splitToStream(line).map(Long::valueOf).collect(toImmutableList()); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException
|
||
public static Order deserialize(String text) { | ||
List<String> items = SPLITTER.splitToList(text); | ||
return of(Long.valueOf(items.get(0)), OrderType.valueOf(items.get(1))); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException
|
||
void addUnblockableDomains(String data) {} | ||
|
||
void removeUnblockableDomains(String data) {} |
Check notice
Code scanning / CodeQL
Useless parameter
|
||
public void reportOrderProcessingStatus(String data) {} | ||
|
||
void addUnblockableDomains(String data) {} |
Check notice
Code scanning / CodeQL
Useless parameter
return null; | ||
} | ||
|
||
public void reportOrderProcessingStatus(String data) {} |
Check notice
Code scanning / CodeQL
Useless parameter
this.httpTransport = httpTransport; | ||
} | ||
|
||
Stream<String> fetchBlockList(BlockList listName) { |
Check notice
Code scanning / CodeQL
Useless parameter
// Make sure add happens after remove. Ask BSA: | ||
} | ||
|
||
private void discoverNewReservedNames(String reservedListName) { |
Check notice
Code scanning / CodeQL
Useless parameter
return null; | ||
} | ||
|
||
class LazyBlockList implements Closeable { |
Check notice
Code scanning / CodeQL
Inner class could be static
String idToken = | ||
new Gson() | ||
.fromJson( | ||
new InputStreamReader(connection.getInputStream(), StandardCharsets.UTF_8), |
Check warning
Code scanning / CodeQL
Potential input resource leak
f4c1487
to
0f06576
Compare
This change is