Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ICANN upload cursor time #2346

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

jianglai
Copy link
Collaborator

@jianglai jianglai commented Mar 4, 2024

The staging job runs at 9AM on the 2nd day of each month, we should set
the cursor to be after that time, otherwise we attempt to upload reports
on the 1st day of each month before they are ready, causing an error
email to be sent to us.


This change is Reviewable

@jianglai jianglai requested a review from CydeWeys March 4, 2024 18:38
@jianglai jianglai enabled auto-merge March 4, 2024 18:38
@jianglai jianglai force-pushed the icann-upload-cursors branch 5 times, most recently from 13aad77 to 1842024 Compare March 6, 2024 18:18
The staging job runs at 9AM on the 2nd day of each month, we should set
the cursor to be after that time, otherwise we attempt to upload reports
on the 1st day of each month before they are ready, causing an error
email to be sent to us.
Copy link
Collaborator Author

@jianglai jianglai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @CydeWeys and @weiminyu)

Copy link
Collaborator

@weiminyu weiminyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @CydeWeys)

@jianglai jianglai added this pull request to the merge queue Mar 7, 2024
Merged via the queue into google:master with commit 40174b8 Mar 7, 2024
8 checks passed
@jianglai jianglai deleted the icann-upload-cursors branch March 7, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants