Add BSA validation job

[weiminyu]

Add the BsaValidateAction class with a first check (for inconsistency between downloaded and persisted labels).

---

This change is 

[weiminyu]

Reviewable status: 0 of 9 files reviewed, 2 unresolved discussions (waiting on @Github-advanced-security[bot])

---

core/src/main/java/google/registry/bsa/BsaValidateAction.java line 93 at r1 (raw file):

Previously, github-advanced-security[bot] wrote…

Useless parameter

The parameter 'job' is never used.

Show more details

Params will be used.

---

core/src/main/java/google/registry/bsa/BsaValidateAction.java line 93 at r1 (raw file):

Previously, github-advanced-security[bot] wrote…

Useless parameter

The parameter 'errors' is never used.

Show more details

Params will be used.

[jianglai]

Please add any new Action to https://cs.opensource.google/nomulus/nomulus/+/master:core/src/main/java/google/registry/module/RequestComponent.java as well.

[weiminyu]

Done.

Reviewable status: 0 of 10 files reviewed, 2 unresolved discussions (waiting on @Github-advanced-security[bot])

[jianglai]

We should add a test to make sure that there's no divergence going forward. Not in this PR, though.

[sarahcaseybot]

Reviewed 4 of 9 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: 5 of 10 files reviewed, 5 unresolved discussions (waiting on @Github-advanced-security[bot], @jianglai, and @weiminyu)

---

core/src/main/java/google/registry/bsa/BsaValidateAction.java line 99 at r2 (raw file):

  ImmutableList<String> checkBsaLabels(String jobName) {
    ImmutableSet<String> downloadedLabels = fetchDownloadedLabels(jobName);
    ImmutableSet<String> persistedLabels = fetchPersistedLabels(/* batchSize= */ 500);

You should make the batch size configurable

---

core/src/main/java/google/registry/bsa/BsaValidateAction.java line 118 at r2 (raw file):

          String.format(
              "Found %d unexpected labels in the DB. Examples: [%s]",
              missingLabels.size(), examples);

This should use unexpectedLabels

---

core/src/main/java/google/registry/bsa/persistence/Queries.java line 55 at r2 (raw file):

                        "SELECT b.label FROM BsaLabel b WHERE b.label > :lastRead ORDER BY b.label",
                        String.class)
                    .setParameter("lastRead", lastRead.orElse(""))

Does this work when lastRead is empty? Does "... WHERE b.label > ORDER BY b.label" work?

[weiminyu]

Reviewable status: 5 of 10 files reviewed, 5 unresolved discussions (waiting on @Github-advanced-security[bot], @jianglai, and @sarahcaseybot)

---

core/src/main/java/google/registry/bsa/BsaValidateAction.java line 99 at r2 (raw file):

Previously, sarahcaseybot wrote…

You should make the batch size configurable

Done.

---

core/src/main/java/google/registry/bsa/BsaValidateAction.java line 118 at r2 (raw file):

Previously, sarahcaseybot wrote…

This should use unexpectedLabels

Done.

---

core/src/main/java/google/registry/bsa/persistence/Queries.java line 55 at r2 (raw file):

Previously, sarahcaseybot wrote…

Does this work when lastRead is empty? Does "... WHERE b.label > ORDER BY b.label" work?

When lastRead is empty the query will be WHERE b.label > '' ORDER BY b.label.
Empty string goes before any other string.

One of the new method in QueriesTest.java tests this.

[sarahcaseybot]

Reviewed 2 of 9 files at r1, 2 of 2 files at r3, all commit messages.
Reviewable status: 9 of 10 files reviewed, 2 unresolved discussions (waiting on @Github-advanced-security[bot] and @jianglai)