Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test to ensure all actions are routable by the RegistryServlet #2361

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

jianglai
Copy link
Collaborator

@jianglai jianglai commented Mar 11, 2024

This change is Reviewable

@jianglai jianglai force-pushed the route-test branch 2 times, most recently from a5230a0 to e16b5b1 Compare March 11, 2024 16:05
Copy link
Collaborator Author

@jianglai jianglai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 8 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jianglai)

@jianglai jianglai requested a review from ptkach March 11, 2024 16:06
@jianglai jianglai enabled auto-merge March 11, 2024 16:06
Copy link
Collaborator

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 8 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ptkach)

@jianglai jianglai added this pull request to the merge queue Mar 12, 2024
Merged via the queue into google:master with commit 6acb14c Mar 12, 2024
8 checks passed
@jianglai jianglai deleted the route-test branch March 12, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants