Upgrade to Jakarta EE 10 Servlet #2362
Conversation
There was a problem hiding this comment.
Reviewed 192 of 207 files at r1, 19 of 19 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jianglai)
jianglai
added
do not merge
jianglai
force-pushed
the
jakarta
branch
2 times, most recently
from
c078032
to
e9bac06
Compare
jianglai
added
do not merge
There was a problem hiding this comment.
Reviewed 188 of 207 files at r1, 7 of 19 files at r2, 13 of 13 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed 11 of 11 files at r5, all commit messages.
Reviewable status:
jianglai
added
kokoro:force-run
There was a problem hiding this comment.
Reviewed 12 of 12 files at r6, all commit messages.
Reviewable status:
Upgrade to using Jakarta EE 10 from Java EE 8 by mostly following the upgrade instructions. Only the servlet package is upgrade. Other Jakarta EE components (like the persistence package that Hibernate depends on) need to be upgraded separately. TESTED=deployed and successfully communicated with the pubapi endpoint for web WHOIS. Note that this currently requires packaing the App Engine runtime per instructions here due to GoogleCloudPlatform/appengine-java-standard#98. This PR will only be merged until the fix is deployed to production (https://rapid.corp.google.com/#/release/serverless_runtimes_run_java/java21_20240310_21_0).
There was a problem hiding this comment.
Reviewed 2 of 2 files at r7, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
Upgrade to using Jakarta EE 10 from Java EE 8 by mostly following the upgrade instructions. Only the servlet package is upgrade. Other Jakarta EE components (like the persistence package that Hibernate depends on) need to be upgraded separately.
TESTED=deployed and successfully communicated with the pubapi endpoint for web WHOIS.
Note that this currently requires packaging the App Engine runtime per instructions here due to GoogleCloudPlatform/appengine-java-standard#98. This PR will only be merged when the fix is deployed to App Engine runtime. (https://rapid.corp.google.com/#/release/serverless_runtimes_run_java/java21_20240310_21_0).
Follow up: The fix has been deployed to App Engine and I've tested this PR without packing the App Engine runtime on alpha.
This change is