Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop should publish field from ReservedList entity #2369

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Drop should publish field from ReservedList entity #2369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a22007
Remove the shouldPublish field from the reservedLIst entity
sarahcaseybot Mar 13, 2024
20bb989
Add generated schema file
sarahcaseybot Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions core/src/main/java/google/registry/model/tld/label/ReservedList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,6 @@ public final class ReservedList
*/
@Insignificant @Transient Map<String, ReservedListEntry> reservedListMap;

// TODO(b/321053918): Remove this field once the column is nullable
@Column(nullable = true)
boolean shouldPublish = true;

@PreRemove
void preRemove() {
tm().query("DELETE FROM ReservedEntry WHERE revision_id = :revisionId")
Expand Down
2 changes: 1 addition & 1 deletion core/src/test/java/google/registry/tools/server/ListReservedListsActionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ void testRun_withWildcard() {
Optional.of("*"),
Optional.empty(),
Optional.empty(),
"^name\\s+.*shouldPublish.*",
"^name\\s+.*",
"^-+\\s+-+",
"^xn--q9jyb4c-private\\s+.*",
"^xn--q9jyb4c-published\\s+.*");
Expand Down
1 change: 0 additions & 1 deletion db/src/main/resources/sql/schema/db-schema.sql.generated
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,7 +693,6 @@
revision_id bigserial not null,
creation_timestamp timestamptz,
name text not null,
should_publish boolean,
primary key (revision_id)
);

Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# This file defines properties used by the Gradle build. It must be kept in
# This file defines properties used by the gradle build. It must be kept in
# sync with config/nom_build.py.
#
# To regenerate, run ./nom_build --generate-gradle-properties
Expand Down