Replace javax.inject with jakarta.inject #2372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianglai
force-pushed
the
jakarta-inject
branch
from
95407a4
to
8661584
Compare
jianglai
commented
Mar 14, 2024
There was a problem hiding this comment.
Reviewed 22 of 22 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jianglai)
gbrodman
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Reviewed 21 of 22 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Note that Dagger currently doesn't work with the Jakarta namespace and we have to cap the jakarta inject package version below 2.0 so that it sill provides classes in the old namespace.
jianglai
force-pushed
the
jakarta-inject
branch
from
8661584
to
72438dc
Compare
jianglai
commented
Mar 14, 2024
There was a problem hiding this comment.
Reviewed 11 of 11 files at r3, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that Dagger currently doesn't work with the Jakarta namespace and
we have to cap the jakarta inject package version below 2.0 so that it
still provides classes in the old namespace.
This change is