Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile to Java 21 bytecode #2374

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

jianglai
Copy link
Collaborator

@jianglai jianglai commented Mar 14, 2024

We have been running in Java 21 runtime for a couple of weeks and every
works as expected.


This change is Reviewable

@jianglai jianglai added do not merge Do not merge this PR. WIP Work in progress. Don't review yet. labels Mar 14, 2024
@jianglai jianglai requested a review from gbrodman March 15, 2024 00:52
@jianglai jianglai removed the WIP Work in progress. Don't review yet. label Mar 15, 2024
Copy link
Collaborator

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jianglai)

@jianglai
Copy link
Collaborator Author

Will hold off for another week for Java 21 runtime to bake a bit more. Planning to merge next week.

Copy link
Collaborator Author

@jianglai jianglai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jianglai)

@jianglai jianglai added do not merge Do not merge this PR. and removed do not merge Do not merge this PR. labels Mar 18, 2024
Copy link
Collaborator Author

@jianglai jianglai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jianglai)

Copy link
Collaborator

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jianglai)

We have been running in Java 21 runtime for a couple of weeks and every
works as expected.
@jianglai jianglai removed the do not merge Do not merge this PR. label Mar 25, 2024
@jianglai jianglai enabled auto-merge March 25, 2024 13:50
@jianglai jianglai added this pull request to the merge queue Mar 25, 2024
Merged via the queue into google:master with commit af1f6e5 Mar 25, 2024
9 of 10 checks passed
@jianglai jianglai deleted the java-21-bytecode branch March 25, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants