Add a separate RegistryLock action for the console #2411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
core/src/test/java/google/registry/ui/server/console/ConsoleRegistryLockActionTest.java
Fixed
Show fixed
Hide fixed
gbrodman
commented
Apr 24, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 12 files reviewed, 1 unresolved discussion (waiting on @Github-advanced-security[bot])
core/src/test/java/google/registry/ui/server/console/ConsoleRegistryLockActionTest.java line 420 at r1 (raw file):
Previously, github-advanced-security[bot] wrote…
Unread local variable
Variable 'Domain otherRegistrar' is never read.
Done.
gbrodman
force-pushed
the
registryLock
branch
2 times, most recently
from
e4df571
to
b141e95
Compare
gbrodman
force-pushed
the
registryLock
branch
2 times, most recently
from
5f4e8e8
to
ed076ff
Compare
|
friendly ping |
ptkach
approved these changes
May 3, 2024
There was a problem hiding this comment.
Reviewed 3 of 12 files at r1, 9 of 9 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Github-advanced-security[bot])
This handles both GET and POST requests. For POST requests it doesn't actually change anything about the domains because we will need to add a verification action (this will be done in a future PR).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles both GET and POST requests. For POST requests it doesn't actually change anything about the domains because we will need to add a verification action (this will be done in a future PR).
This change is