Remove List{Domains,Hosts} commands #2545
Open
+1
−585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CydeWeys
reviewed
Sep 5, 2024
There was a problem hiding this comment.
I'm not following the logic here -- these commands seem to work for me, at least when you don't specify a query that returns too many results? Maybe we should simply change the max results default from MAX_INT to 1000? The queries themselves seem performant enough.
Reviewable status: 0 of 11 files reviewed, all discussions resolved
CydeWeys
reviewed
Sep 5, 2024
There was a problem hiding this comment.
(And for the record, I do use nomulus list_domains on occasion, e.g. to see how many domains we're up to on our .brand TLDs.)
Reviewable status: 0 of 11 files reviewed, all discussions resolved
These commands have been broken for a long time due to result sizes. We can enhance them by pagination. However, since no one has requested a fix, removal makes more sense.
weiminyu
force-pushed
the
remove-list-commands
branch
from
2e3a8ea
to
272b517
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commands have been broken for a long time due to result sizes.
We can enhance them by pagination. However, since no one has requested a fix, removal makes more sense.
This change is