Skip to content

Add text search across trials/samples #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

myanvoos
Copy link
Collaborator

@myanvoos myanvoos commented Jun 24, 2025

This PR adds a text search functionality to the report, allowing the user to search for trials/samples containing a certain keyword. It makes use of and expands the unified data JSON structure that was introduced in #1102 by adding some additional fields to each trial/sample.

Searchable fields:

  • Bug type (for example: SEGV, heap-buffer-overflow)
  • Crash address
  • Sanitizer (for example, AddressSanitizer)
  • Triage
  • Triager prompt

It also adds an intuitive search UI that persists across all three pages so the user can perform the search action regardless of what page they're currently on.

Preview

image

@myanvoos
Copy link
Collaborator Author

/gcbrun exp -n mv -m vertex_ai_gemini-2-5-pro-chat -ag

@myanvoos myanvoos marked this pull request as draft June 25, 2025 02:53
@myanvoos myanvoos changed the title Add text search across trials/samples WIP: Add text search across trials/samples Jun 25, 2025
@myanvoos
Copy link
Collaborator Author

It seems like the parsing logic is not correctly extracting the crash details for them to be searchable and is relying too much on the semantic analyzer log. I'll mark this as draft for now to fix this.

@myanvoos
Copy link
Collaborator Author

myanvoos commented Jun 25, 2025

Update: I extracted the crash details directly using the run logs, made them collapsible in the header, and changed up the search result view to display the full crash symptom string (to avoid excess whitespace). I also added a dependency (ansi-up) to syntax highlight the ANSI formatting, if there are any.

Preview

image

@myanvoos
Copy link
Collaborator Author

/gcbrun exp -n mv -m vertex_ai_gemini-2-5-pro-chat -ag

@myanvoos
Copy link
Collaborator Author

myanvoos commented Jun 25, 2025

JOB: https://console.cloud.google.com/kubernetes/job/us-central1-c/llm-experiment/default/ofg-pr-1134-mv
REPORT: https://llm-exp.oss-fuzz.com/Result-reports/ofg-pr/2025-06-25-1134-mv-comparison/index.html
BUCKET: https://console.cloud.google.com/storage/browser/oss-fuzz-gcb-experiment-run-logs/Result-reports/ofg-pr/2025-06-25-1134-mv-comparison
BUCKET GS: gs://oss-fuzz-gcb-experiment-run-logs/Result-reports/ofg-pr/2025-06-25-1134-mv-comparison

Originally, I also had the ability to search for text in the source code included, but that was removed to make the search results less bloated. Please feel free to let me know if adding it in as well would be useful, or whether the current text search is enough

@myanvoos myanvoos marked this pull request as ready for review June 25, 2025 10:20
@myanvoos myanvoos changed the title WIP: Add text search across trials/samples Add text search across trials/samples Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant