-
Notifications
You must be signed in to change notification settings - Fork 185
Add text search across trials/samples #1134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
/gcbrun exp -n mv -m vertex_ai_gemini-2-5-pro-chat -ag |
It seems like the parsing logic is not correctly extracting the crash details for them to be searchable and is relying too much on the semantic analyzer log. I'll mark this as draft for now to fix this. |
Update: I extracted the crash details directly using the run logs, made them collapsible in the header, and changed up the search result view to display the full crash symptom string (to avoid excess whitespace). I also added a dependency ( Preview |
/gcbrun exp -n mv -m vertex_ai_gemini-2-5-pro-chat -ag |
JOB: https://console.cloud.google.com/kubernetes/job/us-central1-c/llm-experiment/default/ofg-pr-1134-mv Originally, I also had the ability to search for text in the source code included, but that was removed to make the search results less bloated. Please feel free to let me know if adding it in as well would be useful, or whether the current text search is enough |
This PR adds a text search functionality to the report, allowing the user to search for trials/samples containing a certain keyword. It makes use of and expands the unified data JSON structure that was introduced in #1102 by adding some additional fields to each trial/sample.
Searchable fields:
SEGV
,heap-buffer-overflow
)AddressSanitizer
)It also adds an intuitive search UI that persists across all three pages so the user can perform the search action regardless of what page they're currently on.
Preview