Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore comment-only build script #754

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Ignore comment-only build script #754

merged 1 commit into from
Dec 17, 2024

Conversation

DonggeLiu
Copy link
Collaborator

@DonggeLiu DonggeLiu commented Dec 16, 2024 •
edited
Loading

Sometimes LLM suggests a build script with comments-only when it wants to reuse the existing build script, e.g.,

<build script>
# Reuse the existing build.sh
</build script>

This avoids confusing LLM to 'think' the build script works.
Returning '' will make OFG use the existing build script.

@DonggeLiu
Copy link
Collaborator Author

/gcbrun exp -n dg -ag

@DonggeLiu DonggeLiu enabled auto-merge (squash) December 16, 2024 04:14
@DonggeLiu DonggeLiu merged commit fabf4b8 into main Dec 17, 2024
5 checks passed
@DonggeLiu DonggeLiu deleted the ignore-empty-build branch December 17, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverchang oliverchang oliverchang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DonggeLiu @oliverchang