Skip to content

Commit

Permalink
gitoxide: Use updated nightly to fix serde error (#12512)
Browse files Browse the repository at this point in the history
Since around Byron/gitoxide#1536, fuzzing is
broken for `gitoxide` due to an error related to `serde`. As shown there
and in Byron/gitoxide#1596, the error is:

    error[E0658]: `#[diagnostic]` attribute name space is experimental
-->
/rust/registry/src/index.crates.io-6f17d22bba15001f/serde-1.0.210/src/de/mod.rs:536:5
        |
    536 |     diagnostic::on_unimplemented(
        |     ^^^^^^^^^^
        |
= note: see issue #111996
<rust-lang/rust#111996> for more information
= help: add `#![feature(diagnostic_namespace)]` to the crate attributes
to enable
= note: this compiler was built on 2024-02-11; consider upgrading it if
it is out of date

Since rust-lang/rust#111996 is closed as
completed, and similar errors appear to have been fixed in oss-fuzz for
other projects by using the latest nightly toolchain, this makes the
same change for `gitoxide` as was made in:

- #12404 for `starlark-rust`
- #12409 for `rhai`

See also:

- #12410
- serde-rs/serde#2770

cc @Byron
  • Loading branch information
EliahKagan committed Sep 18, 2024
1 parent e5978be commit a06f052
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions projects/gitoxide/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

FROM gcr.io/oss-fuzz-base/base-builder-rust
RUN git clone --depth 1 https://github.com/Byron/gitoxide.git gitoxide
RUN rustup update nightly
WORKDIR gitoxide
RUN rustup component add rust-src
COPY build.sh $SRC/
2 changes: 1 addition & 1 deletion projects/gitoxide/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ for CRATE_DIR in ${FUZZ_CRATE_DIRS[@]};
do
echo "Building crate: $CRATE_DIR"
cd $CRATE_DIR
cargo fuzz build -O --debug-assertions
cargo +nightly fuzz build -O --debug-assertions
FUZZ_TARGET_OUTPUT_DIR=$CARGO_BUILD_TARGET_DIR/x86_64-unknown-linux-gnu/release
for f in fuzz/fuzz_targets/*.rs
do
Expand Down

0 comments on commit a06f052

Please sign in to comment.