infra: Fix possible bugs in jvm coverage report generation #11553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Chan <[email protected]>
arthurscchan
force-pushed
the
jvm-fuzzer-coverage
branch
from
82343ce
to
588a1cf
Compare
|
/gcbrun trial_build.py java --fuzzing-engines libfuzzer --sanitizers coverage |
|
Is this PR still relevant? |
|
/gcbrun trial_build.py jvm --fuzzing-engines libfuzzer --sanitizers coverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #10906, the logic has skipped the removal of duplication for the fuzzer classes in the base directory because fuzzer classes don't have duplication in the jar files. But in some projects, fuzzer classes could also contain duplicates from different fuzzers if they share some common base classes. In this situation, the duplication of the fuzzer classes will still crash the Jacoco report generation and merging. This PR fixes that by reverting the changes in #10906 to remove all duplicate classes first. Then an additional line of logic is added to copy the fuzzer classes from the $OUT directory to ensure only one copy of the same fuzzer class exists in the dump directory. This could avoid duplication of fuzzer-related classes that crash the Jacoco report generation process.