-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC: Speed up compilation by freezing container during compilation. #11940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Command to test:
|
DonggeLiu
reviewed
May 31, 2024
DonggeLiu
approved these changes
Jun 4, 2024
|
||
func WriteTargetArgsAndCommitImage(cmdline []string) { | ||
fmt.Println("WRITE COMMAND") | ||
f, _ := os.OpenFile("/out/statefile.json", os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, os.O_APPEND
caused an invalid JSON format during our hackathon, is it the same case here?
Instead of rebuilding the entire project every time we want to compile a single fuzz target, a better workflow is to build the project once and somehow compile the target against the already compiled project code. This POC does that by interrupting building in when it detects it is compiling the fuzz target. On detection it does the following: 1. Writes the command to /out/statefile TODO: write the cwd. 2. Commits the current container as "frozen" for use later. TODO: make this changeable. 3. Returns 1 so compilation stops. TODO: It would be better to exit the container. This step may be important to prevent clean up of the environment. Then the frozen container can be used to compile fuzz targets against the project without recompiling the project in its entirety. TODO: 1. Support this in oss-fuzz-gen 2. Install docker command line tool in base-builder (or use sneaky inheritance) because it must be used within the container.
manunio
added a commit
to manunio/oss-fuzz
that referenced
this pull request
Jun 22, 2024
…ation. (google#11940)" This reverts commit deef8c5.
manunio
added a commit
to manunio/oss-fuzz
that referenced
this pull request
Jun 24, 2024
…ation. (google#11940)" This reverts commit deef8c5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of rebuilding the entire project every time we want to compile a single fuzz target, a better workflow is to build the project once and somehow compile the target against the already compiled project code.
This POC does that by interrupting building in when it detects it is compiling the fuzz target.
On detection it does the following:
This step may be important to prevent clean up of the environment.
Then the frozen container can be used to compile fuzz targets against the project without recompiling the project in its entirety.
TODO: