Add timeout for target_experiment.py
#11972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Script This PR ensures it won't be delayed by other steps. |
|
This should be able to capture timeout error from I suppose there is no point in re-trying a timeout error? |
oliverchang
approved these changes
May 20, 2024
| 'coverage', | ||
| target_name, | ||
| '-c', | ||
| (f'timeout 30m coverage {target_name}; ret=$?; [ $ret -eq 124 ] ' |
There was a problem hiding this comment.
Can you add a comment for where 124 comes from?
|
/gcbrun skip |
|
/gcbrun skip |
|
The CI failure is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a 3-hour timeout to
target_experiment.py, which should be more than enough given fuzzing timeout is 30 minutes and most successful cloud builds finish in 2.5 hours empirically.