[tinyxml2] Update tinyxml2 fuzzer #11985
Conversation
|
gnbon is a new contributor to projects/tinyxml2. The PR must be approved by known contributors before it can be merged. The past contributors are: DonggeLiu, inferno-chromium, Dor1s, Androbin (unverified), jumde (unverified) |
There was a problem hiding this comment.
We shouldn't change the name of the existing fuzzer as this will cause issues in the oss-fuzz backend.
I can see the existing harness has #if defined( _MSC_VER ) || defined (WIN32) --> will this, however, be true in any OSS-Fuzz build environment?
will await maintainer approval for this.
- Keep the original fuzzer name to avoid OSS-Fuzz backend issues - Remove platform-specific conditional compilation directives - Remove unnecessary headers
|
@DavidKorczynski I made the changes based on your feedback. How do these changes look? |
projects/tinyxml2/xmltest2.cpp
Outdated
| // Entry point for LibFuzzer. | ||
| extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) { | ||
| char pathname[256]; | ||
| sprintf(pathname, "/dev/shm/fuzz-%d", getpid()); |
There was a problem hiding this comment.
does this path always exist? /dev/shm?
There was a problem hiding this comment.
Nope. Would it be better to modify it like this?
oss-fuzz/projects/binutils/fuzz_addr2line.c
Lines 25 to 26 in 7dc6808
it looks fine as such but will await maintainer feedback. |
|
@DavidKorczynski The maintainer is not responding. Is a maintainer approval essential? Or, is there any other way for me to obtain permission? |
|
Approved - and thanks for looking into this |
|
@DavidKorczynski Could you accept this PR? |
Update tinyxml2 fuzzer by myself. Looking forward to approval.