-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix doc timeouts and ooms and allow these options in GH Action #12003
Fix doc timeouts and ooms and allow these options in GH Action #12003
Conversation
report-timeouts: | ||
description: "Whether to report fails due to timeout." | ||
required: false | ||
default: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these should default to true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thanks.
7f117d9
to
4ebe23f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@jonathanmetzman who can merge it? |
With disabled option `report-oom` in GH Action Github reports a warning: "Unexpected input(s) 'report_ooms', valid inputs are ['entryPoint', 'args', 'language', 'fuzz-seconds', 'dry-run', 'sanitizer', 'mode', 'github-token', 'storage-repo', 'storage-repo-branch', 'storage-repo-branch-coverage', 'report-unreproducible-crashes', 'minimize-crashes', 'parallel-fuzzing', 'output-sarif']". The patch follows up commit a7c524d ("Fix doc timeouts and ooms and allow these options in GH Action (google#12003)").
With disabled option `report-oom` in GH Action Github reports a warning: "Unexpected input(s) 'report_ooms', valid inputs are ['entryPoint', 'args', 'language', 'fuzz-seconds', 'dry-run', 'sanitizer', 'mode', 'github-token', 'storage-repo', 'storage-repo-branch', 'storage-repo-branch-coverage', 'report-unreproducible-crashes', 'minimize-crashes', 'parallel-fuzzing', 'output-sarif']". The patch follows up commit a7c524d ("Fix doc timeouts and ooms and allow these options in GH Action (#12003)").
#11723