[infra] Fix jacoco_report_converter.py #12026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Chan <[email protected]>
arthurscchan
force-pushed
the
fix-jacoco-report
branch
from
5274968
to
18b05da
Compare
|
/gcbrun trial_build.py jvm --fuzzing-engines libfuzzer --sanitizers coverage |
|
The failed java projects in the trial run are not due to the changes of this PR. This is good to go. |
DavidKorczynski
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 bugs in the jacoco_report_converter.py in which the src_file and src_path are redefined and overwritten in the loop. These bugs cause both of them to empty after the first iteration. This makes the resulting JSON report summary only contain the first filename to process. This has been mentioned in #11966.
This PR proposes a fix by changing the name of the needed variables. Also, this PR adds in a filter to exclude fuzzer classes in the coverage information as they are not part of the projects. The updated script will include the coverage information for each class that existed in the project source directory (
/out/src) in the summary tag of the resulting summary.json report.