Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasmtime: Fix build #12076

Merged
merged 1 commit into from
Jun 17, 2024
Merged

wasmtime: Fix build #12076

merged 1 commit into from
Jun 17, 2024

Conversation

maflcko
Copy link
Contributor

@maflcko maflcko commented Jun 17, 2024

No description provided.

Copy link

maflcko is a new contributor to projects/wasmtime. The PR must be approved by known contributors before it can be merged. The past contributors are: jeffcharles, saulecabrera, alexcrichton, itsrainy, cfallin, peterhuene, abrown, catenacyber, inferno-chromium

@maflcko
Copy link
Contributor Author

maflcko commented Jun 17, 2024

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=69697

Please approve, if the workaround is acceptable, @alexcrichton .

Copy link
Contributor

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I'll try to keep poking at #12075 in the meantime because this'll be a problem for us eventually where we'll eventually require a nightly past the Feb 12 nightly.

@maflcko
Copy link
Contributor Author

maflcko commented Jun 17, 2024

Indeed, my recommendation would be to revert this temporary workaround in #12075, once it is ready (infra changes generally take longer than project-specific-fixups in my experience).

@jonathanmetzman jonathanmetzman merged commit 05782b8 into google:master Jun 17, 2024
16 checks passed
@maflcko maflcko deleted the 2406-wasmtime branch June 17, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants