Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

knot-dns: Use latest builder #12095

Merged
merged 2 commits into from
Jun 19, 2024
Merged

knot-dns: Use latest builder #12095

merged 2 commits into from
Jun 19, 2024

Conversation

maflcko
Copy link
Contributor

@maflcko maflcko commented Jun 18, 2024

No description provided.

Copy link

maflcko has previously contributed to projects/knot-dns. The previous PR was #11714

@maflcko maflcko marked this pull request as ready for review June 18, 2024 19:19
@maflcko
Copy link
Contributor Author

maflcko commented Jun 19, 2024

An alternative would be to disable the flag that caused this (and is now enabled by default in clang):

diff --git a/projects/knot-dns/build.sh b/projects/knot-dns/build.sh
index 626e91dc9..b0f64b6fe 100755
--- a/projects/knot-dns/build.sh
+++ b/projects/knot-dns/build.sh
@@ -33,6 +33,8 @@ make install
 
 GNUTLS_CONFIGURE_FLAGS=""
 NETTLE_CONFIGURE_FLAGS=""
+CFLAGS="$CFLAGS     -fno-sanitize-address-use-odr-indicator"
+CXXFLAGS="$CXXFLAGS -fno-sanitize-address-use-odr-indicator"
 if [[ $CFLAGS = *sanitize=memory* ]]; then
   GNUTLS_CONFIGURE_FLAGS="--disable-hardware-acceleration"
   NETTLE_CONFIGURE_FLAGS="--disable-assembler --disable-fat"

@jonathanmetzman
Copy link
Contributor

@jfoote do you approve?

@jfoote
Copy link
Contributor

jfoote commented Jun 19, 2024

👍 I haven't been keeping up with knot-dns but this LGTM

@jonathanmetzman jonathanmetzman merged commit 8c1e39f into google:master Jun 19, 2024
15 checks passed
@maflcko maflcko deleted the 2406-k-d branch June 20, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants