-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kimageformats: Use latest builder #12097
Conversation
maflcko has previously contributed to projects/kimageformats. The previous PR was #11714 |
Why is that extra lib needed? |
The error is:
The symbol is a built-in, so the library needs to be included. See also https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/builtins/truncsfhf2.c |
@tsdgeos do you approve? |
1 similar comment
@tsdgeos do you approve? |
My concern is "how am i supposed to know to do that"? I´d be happier if it was a $VARIABLE that one is supposed to use for linking and here we aren´t , do you know if it that exists? If not i guess we can go ahead. |
My understanding is that this is normally not needed to be specified manually. I do not yet understand why it is needed here, so if you want I can mark it as "temporary linker workaround" for this project specifically, so that someone can look into it in the future? |
Yes please, let's do that :) |
Thanks, done. Please approve if it looks ok. |
Looks good to me. Please merge :) |
No description provided.