Directly test bufbuild/protocompile, instead of going through jhump/protoreflect/desc/protoparse #12504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rotoreflect/desc/protoparse (which is now removed on main and is intentionally omitted from v2 of the module)
|
jhump is integrating a new project: |
jhump
commented
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recently merged a long-lived "v2" branch to main in the
github.com/jhump/protoreflectrepo. The v2 of that repo does not include a protoparse package, since that has been effectively replaced bygithub.com/bufbuild/protocompile. (Since v1.15 of protoreflect, the protoparse package is just API veneer on top of protocompile.)After I did that merge of v2 to main, the fuzzer for the project began to fail since the packages are no longer present: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=71629
So this updates the fuzzer configuration to directly test the underlying protocompile module.
There was also a fuzz tester for the
github.com/jhump/protoreflect/dynamicpackage, but it was not actually enabled. (It was disabled in #6369 but neither the PR description nor comment threads describe why this test was problematic 🤷.) Anyhow, that package has also been removed for v2, effectively replaced bygoogle.golang.org/protobuf/types/dynamicpb. So this PR deletes it completely from the oss-fuzz repo.