Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: build: introspector: upload artifacts in all cases #12609

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

DavidKorczynski
Copy link
Collaborator

@DavidKorczynski DavidKorczynski commented Oct 16, 2024

Upload introspector report even when build fails. This is to ensure artifacts from FI light is uploaded for each build.

Upload even when build fails. This is to ensure artifacts from FI light
is uploaded for each build.

Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
@oliverchang
Copy link
Collaborator

/gcbrun trial_build.py all --fuzzing-engines libfuzzer --sanitizers introspector

@DavidKorczynski
Copy link
Collaborator Author

a lot of projects failed, but it looks like they failed due to some issues getting coverage data and not the changes of this PR. I'll rerun now that coverage reports for 17/10 has been uploaded for the majority of projects

@DavidKorczynski
Copy link
Collaborator Author

/gcbrun trial_build.py all --fuzzing-engines libfuzzer --sanitizers introspector

@DavidKorczynski
Copy link
Collaborator Author

A set of builds failed, however, I could not find an instance of the failure being related to the changes of this PR, after going through roughly 25. They also correlated with some other networking issues that seem to have happened on some projects, e.g. apt-get failing.

This is good to go.

@DavidKorczynski DavidKorczynski merged commit 9e9ed9b into master Oct 17, 2024
18 of 19 checks passed
@DavidKorczynski DavidKorczynski deleted the allow-introspector-upload-1 branch October 17, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants