Skip to content

Commit

Permalink
Disable test case failing due to Internet dependency outage (#2327)
Browse files Browse the repository at this point in the history
Add additional signposting to help unfamiliar users troubleshoot
unexpected test failures
  • Loading branch information
andrewpollock authored Jun 19, 2024
1 parent 6980e00 commit 3be5402
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions vulnfeeds/git/repository_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -294,11 +294,12 @@ func TestValidRepo(t *testing.T) {
repoURL: "https://github.com/torvalds/linux",
expectedResult: true,
},
{
description: "Valid repository with a git:// protocol URL",
repoURL: "git://git.infradead.org/mtd-utils.git",
expectedResult: true,
},
// Seems to be having an outage at 2024-06-19
// {
// description: "Valid repository with a git:// protocol URL",
// repoURL: "git://git.infradead.org/mtd-utils.git",
// expectedResult: true,
// },
{
description: "Invalid repository",
repoURL: "https://github.com/andrewpollock/mybogusrepo",
Expand All @@ -316,9 +317,11 @@ func TestValidRepo(t *testing.T) {
},
}
for _, tc := range tests {
// This tests against Internet hosts and may have intermittent failures.
got := ValidRepoAndHasUsableRefs(tc.repoURL)
if diff := cmp.Diff(got, tc.expectedResult); diff != "" {
t.Errorf("test %q: ValidRepo(%q) was incorrect: %s", tc.description, tc.repoURL, diff)
t.Logf("Confirm that %s is reachable with `git ls-remote %s`", tc.repoURL, tc.repoURL)
}
}
}
Expand Down

0 comments on commit 3be5402

Please sign in to comment.