Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle very long fields on vulnerabilities pages #2216

Closed
oliverchang opened this issue May 16, 2024 · 1 comment
Closed

Handle very long fields on vulnerabilities pages #2216

oliverchang opened this issue May 16, 2024 · 1 comment
Assignees
@ZhangChen199102
Labels
enhancement New feature or request frontend Frontend Infrastructure ui UI bugs/FRs

Comments

@oliverchang
Copy link
Collaborator

Currently https://osv.dev/vulnerability/USN-6766-2 looks like this:
image

We should collapse these by default when there's too many, and let the user click through to expand instead.
@oliverchang oliverchang added enhancement New feature or request ui UI bugs/FRs frontend Frontend Infrastructure labels May 16, 2024
@oliverchang
Copy link
Collaborator Author

@ZhangChen199102 @zahraaalizadeh is this something one of you can help with?

@ZhangChen199102 ZhangChen199102 self-assigned this May 16, 2024
@ZhangChen199102 ZhangChen199102 mentioned this issue May 21, 2024
Merged
andrewpollock pushed a commit that referenced this issue May 29, 2024
@ZhangChen199102
Collapse fields on vulnerability page when it's too long (#2223)
d9d8215 
Issue: #2216

Result:
![May-21-2024
15-13-51](https://github.com/google/osv.dev/assets/13760813/3a1fe591-11ae-41d0-9c5e-0f37b8912afd)

Does not render a toggle button if it's a short list:
<img width="813" alt="image"
src="https://github.com/google/osv.dev/assets/13760813/d075284f-fe6a-429e-b994-f4828b58a72e">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZhangChen199102 ZhangChen199102

Labels
enhancement New feature or request frontend Frontend Infrastructure ui UI bugs/FRs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oliverchang @ZhangChen199102 @zahraaalizadeh