Collapse fields on vulnerability page when it's too long #2223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhangChen199102
force-pushed
the
make-long-field-collapsible-on-vulnerability-page
branch
from
c9d28f6 to
08e367c
Compare
ZhangChen199102
commented
May 21, 2024
| @@ -38,7 +38,7 @@ <h1 class="title">{{ vulnerability.id }}</h1> | |||
| {% if vulnerability.related -%} | |||
| <dt>Related</dt> | |||
| <dd> | |||
| <ul class="aliases"> | |||
| <ul class="aliases expandible-list"> | |||
There was a problem hiding this comment.
We can make any <ul>...</ul> collapsible on this page by adding expandible-list class.
ZhangChen199102
commented
May 21, 2024
andrewpollock
approved these changes
May 29, 2024
ZhangChen199102
force-pushed
the
make-long-field-collapsible-on-vulnerability-page
branch
from
08e367c to
99f27a7
Compare
|
Thanks @andrewpollock, can you please help me to merge this PR, I just realised that I lost the write access |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2216
Result:
Does not render a toggle button if it's a short list:
