feat: machine readable record feedback Datastore model #2582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datastore model for holding state on individual OSV record data quality findings Part of google#2189
another-rex
reviewed
Sep 10, 2024
|
|
||
| tests.mock_datetime(self) | ||
|
|
||
| def test_add_finding(self): |
There was a problem hiding this comment.
It is not very clear to me what this test is testing? I don't think there's any _pre_put code on ImportFindings
There was a problem hiding this comment.
This was mostly just me wanting to exercise the thing to make sure it was all anatomically correct
oliverchang
approved these changes
Sep 10, 2024
another-rex
approved these changes
Sep 11, 2024
andrewpollock
added a commit
to andrewpollock/osv.dev
that referenced
this pull request
Nov 25, 2024
…tore model This commit extends google#2582 to include the source of a record. This is so it's possible to search for all records from a specific source. Part of google#2189
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Datastore model for holding state on individual OSV record data quality findings
Part of #2189