Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): set up google cloud profiler #2936

Merged
merged 5 commits into from
Nov 29, 2024
Merged

feat(api): set up google cloud profiler #2936

merged 5 commits into from
Nov 29, 2024

Conversation

cuixq
Copy link
Contributor

@cuixq cuixq commented Nov 29, 2024

#2793

This PR attempts to set up Google Cloud Profiler following this guide.

@cuixq cuixq marked this pull request as ready for review November 29, 2024 02:48
@another-rex
Copy link
Contributor

Related #1305 . I've added google cloud profiler in that PR before, it didn't work that well when used with appengine, though maybe now that it is running in cloud run it will work better.

Looking at the commit history, it looks like you should use the wheel version: 5ef22aa

@cuixq
Copy link
Contributor Author

cuixq commented Nov 29, 2024

since we are with Cloud Run instead of App Engine now, maybe let's try with the default version first?

@cuixq cuixq merged commit 05fa231 into google:master Nov 29, 2024
11 checks passed
@cuixq cuixq deleted the profile branch November 29, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants