Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): match ecosystem names without variants #2986

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

hogo6002
Copy link
Contributor

@hogo6002 hogo6002 commented Dec 13, 2024

Resolves #2963

Updates the API query to support variant-insensitive matching of affected package ecosystem names. A match is found if the package ecosystem name, after removing all variants, is the same as the queried ecosystem name.

TODO:

  • Add integration tests after reput Ubuntu records on prod (after the end-of-year release freeze)

Copy link
Contributor

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we merge normalize and remove_variants? Or are they for two different purposes.

@hogo6002
Copy link
Contributor Author

Could we merge normalize and remove_variants? Or are they for two different purposes.

I personally want to keep them separate for now. normalize is also used in the front end. I think it's good to have a separate function to identify the base ecosystem name (e.g., Debian) of each release (e.g., Debian:11).

@hogo6002 hogo6002 merged commit e100a02 into google:master Dec 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Ubuntu package matching behavior
2 participants