Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add /v1experimental/importfindings/{source} API endpoint for linter findings #2987

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hogo6002
Copy link
Contributor

@hogo6002 hogo6002 commented Dec 16, 2024

Add new API endpoint /v1experimental/importfindings/{source} to return invalid records per source that were found by the linter in the importer.

Sample query (test instance data):
image

Part of #2189

Copy link
Collaborator

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

Do we want to add documentation now?

gcp/api/server.py Outdated Show resolved Hide resolved
gcp/api/server.py Outdated Show resolved Hide resolved
gcp/api/v1/osv_service_v1.proto Outdated Show resolved Hide resolved
@hogo6002 hogo6002 changed the title feat(api): add /v1/importfindings/{source} API endpoint for linter findings add /v1/importfindings/{source} API endpoint for linter findings Dec 19, 2024
@hogo6002 hogo6002 changed the title add /v1/importfindings/{source} API endpoint for linter findings feat(api): add /v1/importfindings/{source} API endpoint for linter findings Dec 19, 2024
@hogo6002 hogo6002 changed the title feat(api): add /v1/importfindings/{source} API endpoint for linter findings feat(api): add /v1experimental/importfindings/{source} API endpoint for linter findings Dec 19, 2024
Copy link
Contributor

@andrewpollock andrewpollock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll see if I can add some basic documentation to this PR today or tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants