Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packetdrill: fix compilation/runtime error for linux 3.x #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nealcardwell
Copy link
Collaborator

For linux 3.10, TCP_CC_INFO and SO_MEMINFO are not supported. When we
define HAVE_SO_MEMINFO / HAVE_TCP_CC_INFO as 0, functions like
write_tcp_bbr_cc_info and write_so_meminfo will not be accessed. So
wrap them with #ifdef and #endif.

Also, for lower linux version, tcp_info option value has less
fields(e.g. 120 bytes). So remove the size assert.

This commit is based on the following packetdrill upstream pull
request, with a slightly tweaked commit description:
#13

Signed-off-by: Neal Cardwell [email protected]

For linux 3.10, TCP_CC_INFO and SO_MEMINFO are not supported. When we
define HAVE_SO_MEMINFO / HAVE_TCP_CC_INFO as 0, functions like
write_tcp_bbr_cc_info and write_so_meminfo will not be accessed. So
wrap them with #ifdef and #endif.

Also, for lower linux version, tcp_info option value has less
fields(e.g. 120 bytes). So remove the size assert.

This commit is based on the following packetdrill upstream pull
request, with a slightly tweaked commit description:
  google#13

Signed-off-by: Neal Cardwell <[email protected]>
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

dcaratti pushed a commit to dcaratti/packetdrill that referenced this pull request Jan 27, 2021
mptcp: remove receive window specification from kernel pkt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants