net-test: packetdrill: Fix tcpi_snd_cwnd in cwnd-moderation-ecn-enter… #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-cwr-no-moderation-700.pkt Linux Kernel commit 7e901ee7b6ab "tcp: avoid slow start during fast recovery on new losses", changes the behavior of the test. In net/ipv4/tcp_input.c function tcp_cwnd_reduction() with added variable newly_lost we end up in the following else branch: else if (flag & FLAG_SND_UNA_ADVANCED && !newly_lost). Now sndcnt = sndcnt = min_t(int, delta, max_t(int, tp->prr_delivered - tp->prr_out, newly_acked_sacked) + 1) = 2. Change the asserted value of tcpi_snd_cwnd from 4 to 5, to match the new kernel behavior. Signed-off-by: Gregory Bell <[email protected]> Reviewed-by: Radu Rendec <[email protected]> Change-Id: I7edcc4aae4f161b83ce174ce7e89c2b14fe2bac0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…-cwr-no-moderation-700.pkt
Linux Kernel commit 7e901ee7b6ab "tcp: avoid slow start during fast recovery on new losses", changes the behavior of the test. In net/ipv4/tcp_input.c function tcp_cwnd_reduction() with added variable newly_lost we end up in the following else branch: else if (flag & FLAG_SND_UNA_ADVANCED && !newly_lost). Now sndcnt = sndcnt = min_t(int, delta, max_t(int, tp->prr_delivered
Change the asserted value of tcpi_snd_cwnd from 4 to 5, to match the new kernel behavior.
Reviewed-by: Radu Rendec [email protected]
Change-Id: I7edcc4aae4f161b83ce174ce7e89c2b14fe2bac0