Merge "Revert "[trace_processor] Add V8WasmScript.wire_bytes"" into main

google · Feb 18, 2025 · 9f28b77 · 9f28b77
2 parents 5e78105 + 25e9db2
commit 9f28b77
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 8 deletions.
diff --git a/protos/perfetto/trace/chrome/v8.proto b/protos/perfetto/trace/chrome/v8.proto
@@ -101,8 +101,6 @@ message InternedV8WasmScript {
   optional int32 script_id = 2;
 
   optional string url = 3;
-  // Raw transferred wasm native module wire bytes.
-  optional bytes wire_bytes = 4;
 }
 
 message InternedV8JsFunction {

diff --git a/protos/perfetto/trace/perfetto_trace.proto b/protos/perfetto/trace/perfetto_trace.proto
@@ -6640,8 +6640,6 @@ message InternedV8WasmScript {
   optional int32 script_id = 2;
 
   optional string url = 3;
-  // Raw transferred wasm native module wire bytes.
-  optional bytes wire_bytes = 4;
 }
 
 message InternedV8JsFunction {

diff --git a/src/trace_processor/importers/proto/v8_tracker.cc b/src/trace_processor/importers/proto/v8_tracker.cc
@@ -322,8 +322,6 @@ tables::V8WasmScriptTable::Id V8Tracker::InternWasmScript(
   row.v8_isolate_id = isolate_id;
   row.internal_script_id = script.script_id();
   row.url = context_->storage->InternString(script.url());
-  row.wire_bytes_base64 = context_->storage->InternString(base::StringView(
-      base::Base64Encode(script.wire_bytes().data, script.wire_bytes().size)));
 
   tables::V8WasmScriptTable::Id script_id =
       context_->storage->mutable_v8_wasm_script_table()->Insert(row).id;

diff --git a/src/trace_processor/tables/v8_tables.py b/src/trace_processor/tables/v8_tables.py
@@ -108,7 +108,6 @@
         C('v8_isolate_id', CppTableId(V8_ISOLATE)),
         C('internal_script_id', CppInt32()),
         C('url', CppString()),
-        C('wire_bytes_base64', CppOptional(CppString())),
         C('source', CppOptional(CppString())),
     ],
     tabledoc=TableDoc(
@@ -118,7 +117,6 @@
             'v8_isolate_id': 'V8 Isolate',
             'internal_script_id': 'Script id used by the V8 engine',
             'url': 'URL of the source',
-            'wire_bytes_base64': 'Raw write bytes of the script',
             'source': 'Actual contents of the script.',
         },
     ),