Google sync #1529
Merged
Google sync #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Startblock: after 2023-11-09 08:00 in US/Pacific and then add reviewer tsudol PiperOrigin-RevId: 580952480
PiperOrigin-RevId: 580952973
We intentionally set f_locals to Unsolvable here: https://github.com/google/pytype/blo[]f1e03c1be303259e72fc1c149ee66f07ba269de/pytype/abstract/_classes.py#L83. Not sure why not handling Unsolvable before didn't cause us any trouble, but it generates some new crashes when I try to enable --bind-decorated-methods. PiperOrigin-RevId: 581052154
This allows functions with optional arguments to still be decorated by `@property` and friends. I'm not sure why people do this, but they do, and it's not technically a type error. Also improves the error message. PiperOrigin-RevId: 581423567
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.