Remove the helper FindOrNull, FindPtrOrNull. #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
cl/703164659
branch
from
cdece4f to
064c10b
Compare
copybara-service
bot
changed the title
These utility are useless and worsens the readability. This is not at all a c++ way to do things. We should rather use the .find and the iterator to check existence. PiperOrigin-RevId: 703480889
copybara-service
bot
force-pushed
the
cl/703164659
branch
from
064c10b to
a70b7b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the helper FindOrNull, FindPtrOrNull.
These utility are useless and worsens the readability. This is not at all a c++ way to do things. We should rather use the .find and the iterator to check existence.