Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use .inst instead of .word in arm64 assembly #350

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use .inst instead of .word in arm64 assembly #350

wants to merge 1 commit into from

Conversation

benbarsdell
Copy link

This ensures the instructions are marked as code instead of data, which is important when using tools like llvm-bolt.

cc @cliffwoolley

@benbarsdell
Use .inst instead of .word in arm64 assembly
de29583 
- This ensures the instructions are marked as code instead of data,
  which is important when using tools like llvm-bolt.
@bjacob
Copy link
Contributor

bjacob commented Dec 18, 2023

i'm no longer working at Google. @talumbau ?

Note, the usage of .word directives to encode ARM dot-product instructions is for historical purposes: back in 2018 this was bleeding-edge and not supported on the then-current Android NDK toolchain. This could all be dropped now. The normal asm instruction to replace the .word directive should always be in the comment on the same line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benbarsdell @bjacob