Check for WIN32 rather than MSVC when building #379
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@asinghvi17 I can't merge this until you sign the CLA. |
|
Hey @jmr, I'd signed the CLA a while ago - did it go through? If the email address on this commit is causing issues I can also force-push to change it. |
|
If the email addresses don't match, it won't work. https://github.com/google/s2geometry/pull/379/checks?check_run_id=30313549872 |
|
@podsvirov @asinghvi17 when is |
|
On Windows value WIN32 defined for all compilers (cl, gcc, clang...), but value MSVC only for cl. |
| @@ -70,7 +70,7 @@ if (WITH_PYTHON) | |||
| find_package(Python3 COMPONENTS Interpreter Development) | |||
| endif() | |||
|
|
|||
| if (MSVC) | |||
| if (WIN32) | |||
| # Use unsigned characters | |||
| add_definitions(-J) | |||
There was a problem hiding this comment.
These are compiler options, so isn't MSVC right? Do other compilers support the MSVC options? or maybe this should be MSVC or something?
|
@asinghvi17 What's this |
This constraint is more general and occurs on all Windows platforms, where
MSVCmay not.xref JuliaPackaging/Yggdrasil#9448, where we encountered this issue - the MSVC condition was not satisfied, but the build is on windows.