Add rate limiting and baseurl #41
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that consumers will not have to manually manage their own rate limiting.
Currently its a rudimentary 60 a minute; the documentation doesn't explicitly show what the rate limits are for the new v1alpha endpoints, if you guys have any more information regarding this i would appreciate it (will also reach out to our csm).
Finally, adding the base url session means that there is no need to write:
Instead, you can just do:
(or probably just do it inline e.g.
session.get(f"rules/{rule_id}")
)