Address CR feedback.

google · Jul 18, 2024 · 2c59948 · 2c59948
1 parent c5df344
commit 2c59948
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/includes/Modules/Reader_Revenue_Manager/Tag_Matchers.php b/includes/Modules/Reader_Revenue_Manager/Tag_Matchers.php
@@ -31,8 +31,8 @@ class Tag_Matchers extends Module_Tag_Matchers implements Tag_Matchers_Interface
 	 */
 	public function regex_matchers() {
 		return array(
-			"/<script\\s+[^>]*src=['|\"]https?:\\/\\/news\\.google\\.com\\/swg\\/js\\/v1\\/swg-basic\\.js['|\"][^>]*>",
-			'/\\(self\\.SWG_BASIC=self\\.SWG_BASIC\\|\\|\\[\\]\\)\\.push/',
+			"/<script\s+[^>]*src=['|\"]https?:\/\/news\.google\.com\/swg\/js\/v1\/swg-basic\.js['|\"][^>]*>/",
+			'/\(self\.SWG_BASIC=self\.SWG_BASIC\|\|\[\]\)\.push/',
 		);
 	}
 }
diff --git a/tests/phpunit/integration/Modules/Reader_Revenue_Manager/Web_TagTest.php b/tests/phpunit/integration/Modules/Reader_Revenue_Manager/Web_TagTest.php
@@ -30,7 +30,7 @@ public function test_register() {
 		$footer_html = $this->capture_action( 'wp_footer' );
 
 		$this->assertStringContainsString( 'Google Reader Revenue Manager snippet added by Site Kit', $footer_html );
-		$this->assertStringContainsString( 'script type="text/javascript" src="https://news.google.com/swg/js/v1/swg-basic.js" id="google_swgjs-js"></script>', $footer_html );
+		$this->assertStringContainsString( '<script type="text/javascript" src="https://news.google.com/swg/js/v1/swg-basic.js" id="google_swgjs-js"></script>', $footer_html ); // phpcs:ignore WordPress.WP.EnqueuedResources.NonEnqueuedScript
 		$this->assertStringContainsString( '(self.SWG_BASIC=self.SWG_BASIC||[]).push(basicSubscriptions=>{basicSubscriptions.init({"type":"NewsArticle","isPartOfType":["Product"],"isPartOfProductId":"' . self::PUBLICATION_ID . ':openaccess","clientOptions":{"theme":"light","lang":"en-US"}});});', $footer_html );
 	}
 }
diff --git a/tests/phpunit/integration/Modules/Reader_Revenue_ManagerTest.php b/tests/phpunit/integration/Modules/Reader_Revenue_ManagerTest.php
@@ -216,7 +216,7 @@ public function test_template_redirect() {
 		$footer_html = $this->capture_action( 'wp_footer' );
 
 		$this->assertStringContainsString( 'Google Reader Revenue Manager snippet added by Site Kit', $footer_html );
-		$this->assertStringContainsString( 'script type="text/javascript" src="https://news.google.com/swg/js/v1/swg-basic.js" id="google_swgjs-js"></script>', $footer_html );
+		$this->assertStringContainsString( '<script type="text/javascript" src="https://news.google.com/swg/js/v1/swg-basic.js" id="google_swgjs-js"></script>', $footer_html ); // phpcs:ignore WordPress.WP.EnqueuedResources.NonEnqueuedScript
 		$this->assertStringContainsString( '(self.SWG_BASIC=self.SWG_BASIC||[]).push(basicSubscriptions=>{basicSubscriptions.init({"type":"NewsArticle","isPartOfType":["Product"],"isPartOfProductId":"' . $publication_id . ':openaccess","clientOptions":{"theme":"light","lang":"en-US"}});});', $footer_html );
 	}