Skip to content

Commit

Permalink
Merge pull request #10098 from google/enhancement/9935-remove-periods
Browse files Browse the repository at this point in the history
Enhancement/9935 remove periods (Follow-up)
  • Loading branch information
tofumatt authored Jan 22, 2025
2 parents 00952da + d988fc5 commit 7c81915
Show file tree
Hide file tree
Showing 8 changed files with 26 additions and 26 deletions.
4 changes: 2 additions & 2 deletions assets/js/modules/ads/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,11 @@ export const registerModule = ( modules ) => {
Icon: AdsIcon,
features: [
__(
'Tagging necessary for your ads campaigns to work will be disabled.',
'Tagging necessary for your ads campaigns to work will be disabled',
'google-site-kit'
),
__(
'Conversion tracking for your ads campaigns will be disabled.',
'Conversion tracking for your ads campaigns will be disabled',
'google-site-kit'
),
],
Expand Down
6 changes: 3 additions & 3 deletions assets/js/modules/adsense/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,15 +62,15 @@ export const registerModule = ( modules ) => {
Icon: AdSenseIcon,
features: [
__(
'Intelligent, automatic ad placement will be disabled.',
'Intelligent, automatic ad placement will be disabled',
'google-site-kit'
),
__(
'You will miss out on revenue from ads placed on your site.',
'You will miss out on revenue from ads placed on your site',
'google-site-kit'
),
__(
'You will lose access to AdSense insights through Site Kit.',
'You will lose access to AdSense insights through Site Kit',
'google-site-kit'
),
],
Expand Down
4 changes: 2 additions & 2 deletions assets/js/modules/analytics-4/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,11 @@ export const registerModule = ( modules ) => {
Icon: AnalyticsIcon,
features: [
__(
'Your site will no longer send data to Google Analytics.',
'Your site will no longer send data to Google Analytics',
'google-site-kit'
),
__(
'Analytics reports in Site Kit will be disabled.',
'Analytics reports in Site Kit will be disabled',
'google-site-kit'
),
],
Expand Down
26 changes: 13 additions & 13 deletions assets/js/modules/module-features.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,47 +43,47 @@ describe( 'Module Features', () => {
[
'ads',
[
'Tagging necessary for your ads campaigns to work will be disabled.',
'Conversion tracking for your ads campaigns will be disabled.',
'Tagging necessary for your ads campaigns to work will be disabled',
'Conversion tracking for your ads campaigns will be disabled',
],
],
[
'adsense',
[
'Intelligent, automatic ad placement will be disabled.',
'You will miss out on revenue from ads placed on your site.',
'You will lose access to AdSense insights through Site Kit.',
'Intelligent, automatic ad placement will be disabled',
'You will miss out on revenue from ads placed on your site',
'You will lose access to AdSense insights through Site Kit',
],
],
[
'analytics-4',
[
'Your site will no longer send data to Google Analytics.',
'Analytics reports in Site Kit will be disabled.',
'Your site will no longer send data to Google Analytics',
'Analytics reports in Site Kit will be disabled',
],
],
[
'pagespeed-insights',
[
'Website performance reports for mobile and desktop will be disabled.',
'Website performance reports for mobile and desktop will be disabled',
],
],
[
'reader-revenue-manager',
[ 'Reader Revenue Manager publication tracking will be disabled.' ],
[ 'Reader Revenue Manager publication tracking will be disabled' ],
],
[ 'search-console', [] ],
[
'sign-in-with-google',
[
'Users will no longer be able to sign in to your WordPress site using their Google Accounts.',
'Users will not be able to create an account on your site using their Google Account (if account creation is enabled).',
'Existing users who have only used Sign in With Google to sign in to your site will need to use WordPress’ “Reset my password” to set a password for their account.',
'Users will no longer be able to sign in to your WordPress site using their Google Accounts',
'Users will not be able to create an account on your site using their Google Account (if account creation is enabled)',
'Existing users who have only used Sign in with Google to sign in to your site will need to use WordPress’ “Reset my password” to set a password for their account',
],
],
[
'tagmanager',
[ 'You will not be able to create tags without updating code.' ],
[ 'You will not be able to create tags without updating code' ],
],
] )(
'should return the correct features for %s module.',
Expand Down
2 changes: 1 addition & 1 deletion assets/js/modules/pagespeed-insights/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export const registerModule = ( modules ) => {
Icon: PageSpeedInsightsIcon,
features: [
__(
'Website performance reports for mobile and desktop will be disabled.',
'Website performance reports for mobile and desktop will be disabled',
'google-site-kit'
),
],
Expand Down
2 changes: 1 addition & 1 deletion assets/js/modules/reader-revenue-manager/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export const registerModule = ( modules ) => {
Icon: ReaderRevenueManagerIcon,
features: [
__(
'Reader Revenue Manager publication tracking will be disabled.',
'Reader Revenue Manager publication tracking will be disabled',
'google-site-kit'
),
],
Expand Down
6 changes: 3 additions & 3 deletions assets/js/modules/sign-in-with-google/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,15 +64,15 @@ export function registerModule( modules ) {
Icon,
features: [
__(
'Users will no longer be able to sign in to your WordPress site using their Google Accounts.',
'Users will no longer be able to sign in to your WordPress site using their Google Accounts',
'google-site-kit'
),
__(
'Users will not be able to create an account on your site using their Google Account (if account creation is enabled).',
'Users will not be able to create an account on your site using their Google Account (if account creation is enabled)',
'google-site-kit'
),
__(
'Existing users who have only used Sign in With Google to sign in to your site will need to use WordPress’ “Reset my password” to set a password for their account.',
'Existing users who have only used Sign in with Google to sign in to your site will need to use WordPress’ “Reset my password” to set a password for their account',
'google-site-kit'
),
],
Expand Down
2 changes: 1 addition & 1 deletion assets/js/modules/tagmanager/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export const registerModule = ( modules ) => {
Icon: TagManagerIcon,
features: [
__(
'You will not be able to create tags without updating code.',
'You will not be able to create tags without updating code',
'google-site-kit'
),
],
Expand Down

0 comments on commit 7c81915

Please sign in to comment.