Simplify setup notification check requirements.

google · Jan 10, 2025 · c2172ee · c2172ee
1 parent 0889c1b
commit c2172ee
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/assets/js/modules/reader-revenue-manager/index.js b/assets/js/modules/reader-revenue-manager/index.js
@@ -96,19 +96,17 @@ export const NOTIFICATIONS = {
 			// Check if the prompt with the legacy key used before the banner was refactored
 			// to use the `notification ID` as the dismissal key, is dismissed.
 			await resolveSelect( CORE_USER ).getDismissedPrompts();
-			const isDismissed = select( CORE_USER ).isPromptDismissed(
+			const isLegacyDismissed = select( CORE_USER ).isPromptDismissed(
 				LEGACY_RRM_SETUP_BANNER_DISMISSED_KEY
 			);
 
-			const canActivateRRMModule = await resolveSelect(
-				CORE_MODULES
-			).canActivateModule( READER_REVENUE_MANAGER_MODULE_SLUG );
-
-			if ( isDismissed === false && canActivateRRMModule ) {
-				return true;
+			if ( isLegacyDismissed ) {
+				return false;
 			}
 
-			return false;
+			return await resolveSelect( CORE_MODULES ).canActivateModule(
+				READER_REVENUE_MANAGER_MODULE_SLUG
+			);
 		},
 		isDismissible: true,
 		dismissRetries: 1,