Enhancement/9902 capitalization first party mode #10010
Open
+35
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build files for cb975ed are ready:
|
|
Size Change: -5 B (0%) Total Size: 1.99 MB
ℹ️ View Unchanged
|
hussain-t
requested changes
Jan 17, 2025
| @@ -136,17 +136,17 @@ public function get_debug_fields() { | |||
|
|
|||
| return array( | |||
| 'first_party_mode_is_enabled' => array( | |||
| 'label' => __( 'First-Party Mode: Enabled', 'google-site-kit' ), | |||
| 'label' => __( 'First-Party mode: Enabled', 'google-site-kit' ), | |||
There was a problem hiding this comment.
Suggested change
| 'label' => __( 'First-Party mode: Enabled', 'google-site-kit' ), | |
| 'label' => __( 'First-party mode: Enabled', 'google-site-kit' ), |
| 'value' => $this->health_check_debug_field_value( $settings['isEnabled'] ), | ||
| 'debug' => $this->health_check_debug_field_debug( $settings['isEnabled'] ), | ||
| ), | ||
| 'first_party_mode_is_fpm_healthy' => array( | ||
| 'label' => __( 'First-Party Mode: Service healthy', 'google-site-kit' ), | ||
| 'label' => __( 'First-Party mode: Service healthy', 'google-site-kit' ), |
There was a problem hiding this comment.
Suggested change
| 'label' => __( 'First-Party mode: Service healthy', 'google-site-kit' ), | |
| 'label' => __( 'First-party mode: Service healthy', 'google-site-kit' ), |
| 'value' => $this->health_check_debug_field_value( $settings['isFPMHealthy'] ), | ||
| 'debug' => $this->health_check_debug_field_debug( $settings['isFPMHealthy'] ), | ||
| ), | ||
| 'first_party_mode_is_script_access_enabled' => array( | ||
| 'label' => __( 'First-Party Mode: Script accessible', 'google-site-kit' ), | ||
| 'label' => __( 'First-Party mode: Script accessible', 'google-site-kit' ), |
There was a problem hiding this comment.
Suggested change
| 'label' => __( 'First-Party mode: Script accessible', 'google-site-kit' ), | |
| 'label' => __( 'First-party mode: Script accessible', 'google-site-kit' ), |
| PaxConnected.scenario = { | ||
| label: 'Modules/Ads/Settings/SettingsView/PAX', | ||
| }; | ||
| PaxConnected.scenario = {}; |
There was a problem hiding this comment.
Since the label property was removed, a new set of VRT images have been added. Can you please remove the old images?
…thub.com:google/site-kit-wp into enhancement/9902-capitalization-first-party-mode.
|
Thank you @hussain-t for reviewing the PR and adding feedback. I've made the suggested changes. Can you please review these changes if those are looking good? Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist