Update references to "One Tap" for consistency. #10184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build files for 44ee435 have been deleted. |
|
Size Change: -3 B (0%) Total Size: 2 MB
ℹ️ View Unchanged
|
techanvil
requested changes
Feb 6, 2025
There was a problem hiding this comment.
Hey @aaemnnosttv, the code changes LGTM, just one question about the changelog.
| @@ -31,7 +31,7 @@ | |||
|
|
|||
| * Add `library_name` parameter to Sign in with Google button. See [#9924](https://github.com/google/site-kit-wp/issues/9924). | |||
| * Add incremental ESLint rule to avoid defining `scenario.label` on stories. See [#9865](https://github.com/google/site-kit-wp/issues/9865). | |||
| * Add option to enable "One-tap" sign-in across site when using Sign in with Google. See [#9861](https://github.com/google/site-kit-wp/issues/9861). | |||
| * Add option to enable "One Tap" sign-in across site when using Sign in with Google. See [#9861](https://github.com/google/site-kit-wp/issues/9861). | |||
There was a problem hiding this comment.
@aaemnnosttv, did you mean to amend the changelog? It obviously reads more correctly, I'm just wondering if we do amend changelogs for previous versions.
There was a problem hiding this comment.
I did, yes. I agree we don't normally make updates to the changelog, but I don't think there is any reason not to in this case as it's not a meaning-altering change.
techanvil
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist