UseInViewSelect

[zutigrm]

Summary

Addresses issue:

• Optimize useInViewSelect #8789

Relevant technical choices

PR Author Checklist

• My code is tested and passes existing unit tests.
• My code has an appropriate set of unit tests which all pass.
• My code is backward-compatible with WordPress 5.2 and PHP 7.4.
• My code follows the WordPress coding standards.
• My code has proper inline documentation.
• I have added a QA Brief on the issue linked above.
• I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

• Run the code.
• Ensure the acceptance criteria are satisfied.
• Reassess the implementation with the IB.
• Ensure no unrelated changes are included.
• Ensure CI checks pass.
• Check Storybook where applicable.
• Ensure there is a QA Brief.

Merge Reviewer Checklist

• Ensure the PR has the correct target branch.
• Double-check that the PR is okay to be merged.
• Ensure the corresponding issue has a ZenHub release assigned.
• Add a changelog message to the issue.

[github-actions]

Build files for 8672821 have been deleted.

[eugene-manuilov]

Thanks, @zutigrm. Mostly looks good to me. Left one comment.

[zutigrm]

@eugene-manuilov Thanks, I updated PR. I noticed that few key metrics widgets were stuck in loading state, so after digging up a bit, I also needed to update the usage of this hook, as we tend to use it for fetching reports, so I updated the usage to include proper dependencies - beside the initial resolution of some dependencies, report options can update when reference date is changed on the dashboard, so this PR grew a bit in number of files that needed editing.

[eugene-manuilov]

Great job, @zutigrm. Almost looks good to me. Left two minor comments for you and then it should be good to go.

[zutigrm]

Thanks @eugene-manuilov , PR updated

[eugene-manuilov]

Thanks, @zutigrm. LGTM.

[aaemnnosttv]

I noticed that few key metrics widgets were stuck in loading state, so after digging up a bit, I also needed to update the usage of this hook, as we tend to use it for fetching reports, so I updated the usage to include proper dependencies - beside the initial resolution of some dependencies, report options can update when reference date is changed on the dashboard, so this PR grew a bit in number of files that needed editing.

Thanks @zutigrm – while I'm not opposed to the addition of dependencies in the usage, it shouldn't have been necessary here. This is likely due to a related flaw in the initial implementation which set deps = [] by default. The inclusion of the mapSelect in deps which this issue was intended to fix prevented this from being a problem since mapSelect was always different. Removing it caused our deps to use the default empty array in any instance where we weren't passing deps explicitly. This resulted in the selector callback never updating when its dependencies changed. Again, it's good to address, but it ultimately resulted in a much larger change than was necessary.

I've opened #9009 to address the fix for the default.