Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate E2E tests #9711

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Conversation

benbowler
Copy link
Collaborator

@benbowler benbowler commented Nov 20, 2024

Summary

Addresses issue:

Relevant technical choices

Base branch that splits the E2E tests while retaining the existing package versions to confirm E2Es can pass with these versions before exploring package upgrades.

I tried jumping to the latest versions but the tests failed to start. I'll create a separate PR to bring the packages to the highest version that continues to run the stories effectively.

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link

github-actions bot commented Nov 20, 2024

Build files for 5f281df are ready:

@benbowler benbowler changed the title Isolate E2E tests and puppeteer tests running but with failures. Isolate E2E tests and update puppeteer. Nov 20, 2024
@benbowler benbowler mentioned this pull request Nov 19, 2024
3 tasks
@benbowler benbowler changed the title Isolate E2E tests and update puppeteer. Isolate E2E tests Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant